feat: support lazy compilation in multi environments#5446
Merged
chenjiahan merged 1 commit intomainfrom Jun 19, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates lazyCompilationMiddleware to support lazy compilation for multi environments by removing the multi-compiler check.
- Remove the conditional logic that extracted the first compiler from a multi-compiler; the middleware now directly receives the entire compiler.
- Update the import statements accordingly.
Comments suppressed due to low confidence (2)
packages/core/src/server/devMiddlewares.ts:146
- The removal of the multi-compiler check means that lazyCompilationMiddleware now receives the full compiler instance. Please verify that the middleware is designed to handle multi-compiler setups without extracting a specific compiler and update the documentation if needed.
rspack.experiments.lazyCompilationMiddleware(compiler) as RequestHandler,
packages/core/src/server/devMiddlewares.ts:4
- [nitpick] Since the isMultiCompiler function is no longer used, ensure that any related documentation or comments are updated to reflect that lazyCompilationMiddleware now directly accepts a multi-compiler instance.
import { pick } from '../helpers';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazyCompilationMiddlewarenow supports lazy compilation when using multiple compiler.Related Links
Checklist